Michael Brown has posted comments on this change. Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options ......................................................................
Patch Set 1: > Just curious, what are the other modules that use cli_options? Are > they inside the Impala repo? You can use 'git grep' to find cases of cli_options or cli_options.create_cluster, or any pattern, really. The stress test is under concurrent_select.py (though again, by luck it doesn't tend to hit this). Another entry point is testdata/bin/load_nested.py, which is used in our data loading. Typical testing wouldn't have caught this though. -- To view, visit http://gerrit.cloudera.org:8080/4555 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a2915e6db85ddb3d8e1bce8035eccd0c9324b4b Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: No
