Ishaan Joshi has posted comments on this change. Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4555/2/tests/comparison/cli_options.py File tests/comparison/cli_options.py: Line 115: '--hive-user', default='hive', Nit: use DEFAULT_HIVE_USER and DEFAULT_HIVE_PASSWORD instead of the raw string. -- To view, visit http://gerrit.cloudera.org:8080/4555 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a2915e6db85ddb3d8e1bce8035eccd0c9324b4b Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Ishaan Joshi <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
