Michael Brown has posted comments on this change. Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options ......................................................................
Patch Set 3: Code-Review+1 (2 comments) done; carry +1 Trying to fix a build blocker here, so I request we avoid the nits any further. http://gerrit.cloudera.org:8080/#/c/4555/1/tests/comparison/cli_options.py File tests/comparison/cli_options.py: PS1, Line 89: > Maybe rename this to parser here and elsewhere to be consistent with add_mi Done http://gerrit.cloudera.org:8080/#/c/4555/2/tests/comparison/cli_options.py File tests/comparison/cli_options.py: Line 115: > Nit: use DEFAULT_HIVE_USER and DEFAULT_HIVE_PASSWORD instead of the raw str Done -- To view, visit http://gerrit.cloudera.org:8080/4555 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a2915e6db85ddb3d8e1bce8035eccd0c9324b4b Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Ishaan Joshi <ish...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-HasComments: Yes
