Hello Sahil Takiar, David Knupp,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4555
to look at the new patch set (#3).
Change subject: IMPALA-4207: test infra: move Hive options from connection to
cluster options
......................................................................
IMPALA-4207: test infra: move Hive options from connection to cluster options
Various test tools and frameworks, including the stress test, random
query generator, and nested types loader, share common modules. This
change
IMPALA-3980: qgen: re-enable Hive as a target database
made changes to tests.comparison.cli_options, the shared command line
option module, and to tests.comparison.cluster, the shared module for
modeling various Impala clusters. Those changes were for the random
query generator, but didn't take into account the other shared entry
points. It was possible to call some of those entry points in such a way
as to produce an exception, because the Hive-related options are now
required for miniclusters, but the Hive-related options weren't always
being initialized in those entry points.
The simple fix is to say that, because Hive settings are now needed to
create Minicluster objects, make the Hive options initialized with
cluster options, not connection options. While I was making these
changes, I fixed all flake8 problems in this file.
Testing:
- qgen/minicluster unit tests (regression test)
- full private data load job, including load_nested.py (bug
verification)
- data_generator.py run (regression test), long enough to verify
connection to the minicluster, using both Hive and Impala
- discrepancy_searcher.py run (regression test), long enough verify
connection to the minicluster, using both Hive and Impala
- concurrent_select.py (in typical mode using a CM host, this is a
regression check; from the command line against the minicluster, this
is a bug verification)
Change-Id: I2a2915e6db85ddb3d8e1bce8035eccd0c9324b4b
---
M tests/comparison/cli_options.py
M tests/comparison/cluster.py
2 files changed, 124 insertions(+), 78 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/4555/3
--
To view, visit http://gerrit.cloudera.org:8080/4555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2a2915e6db85ddb3d8e1bce8035eccd0c9324b4b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <[email protected]>
Gerrit-Reviewer: David Knupp <[email protected]>
Gerrit-Reviewer: Ishaan Joshi <[email protected]>
Gerrit-Reviewer: Michael Brown <[email protected]>
Gerrit-Reviewer: Sahil Takiar <[email protected]>
Gerrit-Reviewer: Taras Bobrovytsky <[email protected]>
