Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4423: Correct but conservative implementation of Subquery.equals(). ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4923/1//COMMIT_MSG Commit Message: PS1, Line 15: Corrected an existing test Hm, didn't seen any changes in the result plans, only the modifications in the actual sql statements. http://gerrit.cloudera.org:8080/#/c/4923/1/fe/src/main/java/org/apache/impala/analysis/Subquery.java File fe/src/main/java/org/apache/impala/analysis/Subquery.java: Line 154: * conservative and only considers Subqueries equal if their toSql() matches. Maybe also emphasize that equivalent statements will not be considered equal based on this implementation. -- To view, visit http://gerrit.cloudera.org:8080/4923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5562d98ce36507aa5e253323e184fd42b54f27ed Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-HasComments: Yes
