Hello Dimitris Tsirogiannis,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4923
to look at the new patch set (#3).
Change subject: IMPALA-4423: Correct but conservative implementation of
Subquery.equals().
......................................................................
IMPALA-4423: Correct but conservative implementation of Subquery.equals().
The underlying problem was for trivial/constant [NOT] EXISTS subqueries
we substituted out Subqueries with bool literals using an ExprSubstitutionMap,
but the Subquery.equals() function was not implemented properly, so we ended
up matching Subqueries to the wrong entry in the ExprSubstitutionMap.
This could ultimately lead to wrong plans and results.
Testing: Corrected an existing test and modified an existing test for
extra coverage.
Change-Id: I5562d98ce36507aa5e253323e184fd42b54f27ed
---
M fe/src/main/java/org/apache/impala/analysis/Subquery.java
M
testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test
2 files changed, 41 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/4923/3
--
To view, visit http://gerrit.cloudera.org:8080/4923
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5562d98ce36507aa5e253323e184fd42b54f27ed
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]>
