Alex Behm has posted comments on this change. Change subject: IMPALA-4423: Correct but conservative implementation of Subquery.equals(). ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4923/2/fe/src/main/java/org/apache/impala/analysis/Subquery.java File fe/src/main/java/org/apache/impala/analysis/Subquery.java: PS2, Line 153: Returns true if the toSql() of the Subqueries is identical. May return false for : * equivalent statements even due to minor syntactic differences like parenthesis. > Much better, thanks. Done http://gerrit.cloudera.org:8080/#/c/4923/2/testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test File testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test: PS2, Line 1757: FALSE > TRUE Oops, copy/paste mistake. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/4923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5562d98ce36507aa5e253323e184fd42b54f27ed Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-HasComments: Yes
