Alex Behm has posted comments on this change. Change subject: IMPALA-4423: Correct but conservative implementation of Subquery.equals(). ......................................................................
Patch Set 1: (3 comments) Thanks for the quick CR! http://gerrit.cloudera.org:8080/#/c/4923/1//COMMIT_MSG Commit Message: PS1, Line 15: Corrected an existing test > Hm, didn't seen any changes in the result plans, only the modifications in Added a CR comment in the .test file to point you to the changes. http://gerrit.cloudera.org:8080/#/c/4923/1/fe/src/main/java/org/apache/impala/analysis/Subquery.java File fe/src/main/java/org/apache/impala/analysis/Subquery.java: Line 154: * conservative and only considers Subqueries equal if their toSql() matches. > Maybe also emphasize that equivalent statements will not be considered equa Done http://gerrit.cloudera.org:8080/#/c/4923/1/testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test File testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test: Line 1771 This existing test case expected incorrect results because the last subquery should evaluate to FALSE and we should have an EmptySet plan - but we have a scan here. Instead of changing the expected results, I changed the query to cover an additional interesting case that matches the currently expected plan. I also modified the test right above here for some extra coverage. Notice that the subquery there is the same one as the one modified here. I now also added a new test at the bottom straight from the JIRA. -- To view, visit http://gerrit.cloudera.org:8080/4923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5562d98ce36507aa5e253323e184fd42b54f27ed Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-HasComments: Yes
