Matthew Jacobs has posted comments on this change. Change subject: Add Kudu cmake utilities ......................................................................
Patch Set 1: (3 comments) docker images/dev setup puppet script may need to be updated to use the new cmake http://gerrit.cloudera.org:8080/#/c/5656/1/CMakeLists.txt File CMakeLists.txt: PS1, Line 17: : cmake_minimum_required(VERSION 3.2.3) is this installed on our build machines? http://gerrit.cloudera.org:8080/#/c/5656/1/cmake_modules/kudu_cmake_fns.txt File cmake_modules/kudu_cmake_fns.txt: PS1, Line 19: : # Note: cmake in thirdparty/ will always meet this minimum. this comment doesn't seem to make sense for us either PS1, Line 27: exported Kudu C++ client remove client reference -- To view, visit http://gerrit.cloudera.org:8080/5656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibaae645d650ab1555452e4cc2574d6c84a90d941 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
