Henry Robinson has posted comments on this change. Change subject: Add Kudu cmake utilities ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5656/2/cmake_modules/kudu_cmake_fns.txt File cmake_modules/kudu_cmake_fns.txt: PS2, Line 26: # add_library() wrapper that adds a second variant of the library, suffixed with : # "_exported" and which is compiled with special visibility flags to hide all symbols : # except those that are part of the public ABI. > this doesn't seem to be true; the code differs from the kudu impl Doh, you're right; I've had this file in my branch so long I misremembered its provenance slightly. ADD_EXPORTED_LIBRARY is mostly just a wrapper for add_library() now. I updated the comments to that effect. -- To view, visit http://gerrit.cloudera.org:8080/5656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibaae645d650ab1555452e4cc2574d6c84a90d941 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
