Matthew Jacobs has posted comments on this change. Change subject: Add Kudu cmake utilities ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5656/2/cmake_modules/kudu_cmake_fns.txt File cmake_modules/kudu_cmake_fns.txt: PS2, Line 26: # add_library() wrapper that adds a second variant of the library, suffixed with : # "_exported" and which is compiled with special visibility flags to hide all symbols : # except those that are part of the public ABI. this doesn't seem to be true; the code differs from the kudu impl PS2, Line 30: # There are two different kinds of exported libraries: internal and leaf. : # Internal libraries are static archives while leaf libraries are shared : # objects built from internal libraries. Why do we need this? Maybe I'm missing context- Is there a doc or readme explaining how the kudu libraries in impala will be included/linked/work? -- To view, visit http://gerrit.cloudera.org:8080/5656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibaae645d650ab1555452e4cc2574d6c84a90d941 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
