Henry Robinson has posted comments on this change. Change subject: Add Kudu cmake utilities ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5656/2/cmake_modules/kudu_cmake_fns.txt File cmake_modules/kudu_cmake_fns.txt: PS2, Line 30: # There are two different kinds of exported libraries: internal and leaf. : # Internal libraries are static archives while leaf libraries are shared : # objects built from internal libraries. > Why do we need this? Maybe I'm missing context- Is there a doc or readme ex These are needed to so that we can import kudu's CMakeLists.txt without significant alteration. See https://github.com/henryr/Impala/blob/0ef5ce0a18eb734dc8caedfca2752dfd4f513ba2/be/src/kudu/util/CMakeLists.txt for the main case where they're used. -- To view, visit http://gerrit.cloudera.org:8080/5656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibaae645d650ab1555452e4cc2574d6c84a90d941 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
