Tim Armstrong has posted comments on this change. Change subject: IMPALA-4678: move query MemTracker into QueryState ......................................................................
Patch Set 5: (2 comments) Discussed a couple of the outstanding comments offline with Marcel. Made updates to the patch accordingly http://gerrit.cloudera.org:8080/#/c/5630/4/be/src/runtime/query-state.h File be/src/runtime/query-state.h: Line 120: > move functions to bottom Done. Mostly I've seen functions at the top in backend code - this class seems to use the opposite convention so I guess it makes sense to be locally consistent. Line 135: /// Create QueryState w/ copy of query_ctx and refcnt of 0. > inline? Not sure what you intended here. -- To view, visit http://gerrit.cloudera.org:8080/5630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6b46652932b5638993623e98d1f0d60d8380ba0 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
