Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4678: move query MemTracker into QueryState ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5630/4/be/src/runtime/query-state.h File be/src/runtime/query-state.h: Line 135: std::unique_ptr<MemTracker> query_mem_tracker_; > Not sure what you intended here. MemTracker query_mem_tracker_ as opposed to unique_ptr<MemTracker> query_mem_tracker_ -- To view, visit http://gerrit.cloudera.org:8080/5630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6b46652932b5638993623e98d1f0d60d8380ba0 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
