Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4593,IMPALA-4635: fix some python build issues ......................................................................
Patch Set 2: (3 comments) nice! did you try running this on a system where kudu is not supported, or setting KUDU_IS_SUPPORTED=false ? http://gerrit.cloudera.org:8080/#/c/6218/2/infra/python/bootstrap_virtualenv.py File infra/python/bootstrap_virtualenv.py: Line 24: # instead. It'd be helpful to have the nice description from the commit message here too. PS2, Line 90: exec_cmd does this really throw if the command doesn't exist? I couldn't find docs for it. PS2, Line 104: "ccache " + cc better to use format() -- To view, visit http://gerrit.cloudera.org:8080/6218 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e807510eddeb354069e0478363f649a1c1b75cf Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
