Tim Armstrong has posted comments on this change. Change subject: IMPALA-4593,IMPALA-4635: fix some python build issues ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/6218/3/infra/python/bootstrap_virtualenv.py File infra/python/bootstrap_virtualenv.py: PS3, Line 28: Every time this script is run > nit: this makes it sound like this might be run multiple times It is run multiple times - every time impala-python is run. http://gerrit.cloudera.org:8080/#/c/6218/4/infra/python/bootstrap_virtualenv.py File infra/python/bootstrap_virtualenv.py: Line 113: if use_ccache(): cc = "ccache {}".format(cc) This format syntax isn't supported in older Python versions (this script needs to support them). Line 206: '''Installs the Kudu python module if possible, which depends on the toolchain and I ran into this issues when using toolchain gcc on CentOS5. Tested that this workaround works. -- To view, visit http://gerrit.cloudera.org:8080/6218 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e807510eddeb354069e0478363f649a1c1b75cf Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
