Tim Armstrong has posted comments on this change. Change subject: IMPALA-4593,IMPALA-4635: fix some python build issues ......................................................................
Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/6218/2/infra/python/bootstrap_virtualenv.py File infra/python/bootstrap_virtualenv.py: Line 24: # instead. > It'd be helpful to have the nice description from the commit message here t Done PS2, Line 90: exec_cmd > does this really throw if the command doesn't exist? I couldn't find docs f It's a wrapper around popen defined on line 72 PS2, Line 104: "ccache " + cc > better to use format() Done Line 115: if cc is not None: env["CC"] = cc > Else bail with a proper error message? What's the consequence of possibly u We won't have toolchain gcc during the first phase of bootstrapping so we need to fail gracefully in that case. I changed this so that it sets CC to a bogus value if toolchain gcc is not available. This revealed a bunch of other packages that used a C compiler. Line 189: LOG.debug("Skipping compiled deps: cc not available") > What's the use case for continuing here as opposed to throwing an error. This code can execute before we've bootstrapped the toolchain, so it needs to fail gracefully. I added comments to explain the bootstrap process better. Line 326: if install_compiled_deps_if_possible(): > Are these only needed for Kudu? If so consider only doing this when KUDU_IS It turns out that a bunch of other packages have some compiled files. I don't see much advantage to skipping this in that special case and it seems simpler to explain a general compiled dependency phase instead of splitting out a compiled-kudu-dependencies phase. -- To view, visit http://gerrit.cloudera.org:8080/6218 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e807510eddeb354069e0478363f649a1c1b75cf Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
