Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4593,IMPALA-4635: fix some python build issues ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/6218/2/infra/python/bootstrap_virtualenv.py File infra/python/bootstrap_virtualenv.py: PS2, Line 90: process > It's a wrapper around popen defined on line 72 ah wow, right above this. thanks. was thrown off by this: https://pypi.python.org/pypi/exec_cmd http://gerrit.cloudera.org:8080/#/c/6218/3/infra/python/bootstrap_virtualenv.py File infra/python/bootstrap_virtualenv.py: PS3, Line 28: Every time this script is run nit: this makes it sound like this might be run multiple times http://gerrit.cloudera.org:8080/#/c/6218/3/infra/python/deps/download_requirements File infra/python/deps/download_requirements: PS3, Line 32: really nice to get rid of this, it was annoying ot have to change the kudu version in 2 places when upgrading -- To view, visit http://gerrit.cloudera.org:8080/6218 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e807510eddeb354069e0478363f649a1c1b75cf Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
