Tim Armstrong has posted comments on this change. Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6328/1/be/src/exec/parquet-column-readers.cc File be/src/exec/parquet-column-readers.cc: Line 802: bool success = stream_->GetBytes( I feel like this pattern (returning a bool and setting status on error) is pretty error-prone. In a couple of perf-critical places we use it because it's faster than returning a Status (e.g. partitioned-hash-join-node), but I don't see a reason to use it here. We could consider inverting it for GetBytes() - returning Status and setting a bool* to indicate success. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/6328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie22a8cf6b53f507c378c2efe302482409935184e Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
