Tim Armstrong has posted comments on this change. Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6328/1/be/src/exec/parquet-column-readers.cc File be/src/exec/parquet-column-readers.cc: Line 802: bool success = stream_->GetBytes( > What would be the benefit of the bool* if we always return a Status? We use this pattern when things are retryable (e.g. in a lot of spilling code, false + OK status means "we didn't succeed, but you should free memory and retry). You make a good point - GetBytes() doesn't actually do that. We could just change it to return a Status. I wonder if this is some vestige of an optimisation from when Status was much more expensive. -- To view, visit http://gerrit.cloudera.org:8080/6328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie22a8cf6b53f507c378c2efe302482409935184e Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
