Lars Volker has posted comments on this change. Change subject: IMPALA-4701: make distcc work reliably with clang ......................................................................
Patch Set 5: (1 comment) Apologies for leaving yet another comment. Feel free to ignore it. http://gerrit.cloudera.org:8080/#/c/6493/5/bin/distcc/distcc_env.sh File bin/distcc/distcc_env.sh: Line 120: -not -path '*thirdparty*' | xargs rm -rf > While I'm here, this wasn't updated to take into account the toolchain I think it would be safer to use find's -print0 parameter and xargs -0 here, otherwise files with spaces will be an issue. On second thought, you could do something like find . -name "FILE-TO-FIND" -exec rm -rf {} \; and do away with xargs altogether. -- To view, visit http://gerrit.cloudera.org:8080/6493 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I199b245fb14b6c3484b66339a7d4b37d74755af7 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
