Jim Apple has posted comments on this change. Change subject: IMPALA-4701: make distcc work reliably with clang ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/6493/5/bin/distcc/distcc_env.sh File bin/distcc/distcc_env.sh: Line 120: -not -path '*thirdparty*' | xargs rm -rf > I think it would be safer to use find's -print0 parameter and xargs -0 here -execdir is the new -exec: -execdir command ; -execdir command {} + Like -exec, but the specified command is run from the subdirectory containing the matched file, which is not normally the directory in which you started find. This a much more secure method for invoking commands, as it avoids race conditions during resolution of the paths to the matched files. -- To view, visit http://gerrit.cloudera.org:8080/6493 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I199b245fb14b6c3484b66339a7d4b37d74755af7 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
