Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4701: make distcc work reliably with clang
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6493/5/bin/distcc/distcc_env.sh
File bin/distcc/distcc_env.sh:

Line 120:       -not -path '*thirdparty*'  | xargs rm -rf
> -execdir is the new -exec:
I switched to -exec.

I couldn't get -execdir to work reliably, I think because we're trying to 
delete directories. I don't think there are any security implications since 
we're only working within the Impala tree.


-- 
To view, visit http://gerrit.cloudera.org:8080/6493
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I199b245fb14b6c3484b66339a7d4b37d74755af7
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Jim Apple <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: Yes

Reply via email to