Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/6502
Change subject: IMPALA-5130: fix race in MemTracker::EnableReservationReporting() ...................................................................... IMPALA-5130: fix race in MemTracker::EnableReservationReporting() MemTracker::LogUsage() and MemTracker::EnableReservationReporting() could race, with LogUsage() seeing a partially-constructed 'reservation_counters_' value and crashing. This patch fixes that issue by atomically swapping in 'reservation_counters_' so that no threads see a partially-constructed value. While we're here, swap boost::mutex for the higher-performance SpinLock. Change-Id: I2434c952d97c46040e29fca2327c244dd30599d2 --- M be/src/common/atomic.h M be/src/runtime/mem-tracker.cc M be/src/runtime/mem-tracker.h 3 files changed, 37 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/6502/1 -- To view, visit http://gerrit.cloudera.org:8080/6502 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2434c952d97c46040e29fca2327c244dd30599d2 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]>
