Tim Armstrong has posted comments on this change. Change subject: IMPALA-5130: fix race in MemTracker::EnableReservationReporting() ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6502/2/be/src/runtime/mem-tracker.cc File be/src/runtime/mem-tracker.cc: Line 251: lock_guard<SpinLock> l(child_trackers_lock_); > why do we need to take this lock earlier? Oops, missed that. That was an accidental change - I was experimenting with a different solution and didn't fully undo my changes. -- To view, visit http://gerrit.cloudera.org:8080/6502 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2434c952d97c46040e29fca2327c244dd30599d2 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
