Dan Hecht has posted comments on this change. Change subject: IMPALA-5130: fix race in MemTracker::EnableReservationReporting() ......................................................................
Patch Set 3: Code-Review+2 This is fine, though it would be nice if memtracker/reservationtracker initialization happened in a more controlled and systematic way (i.e. not registered into the tree until fully initialized). But I'm not sure this really explains the crash you have in the jira. Are you suspecting that the compiler is reordering the construction of the reservation tracker and the write of the scoped_ptr? Or that the scope_ptr read/write is being broken into multiple instructions? -- To view, visit http://gerrit.cloudera.org:8080/6502 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2434c952d97c46040e29fca2327c244dd30599d2 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
