Tim Armstrong has posted comments on this change. Change subject: IMPALA-5130: fix race in MemTracker::EnableReservationReporting() ......................................................................
Patch Set 3: Before we were assigning the scoped_ptr then initialising the memory, so the uninitialised or partially initialised structure was visible to other threads. ReservationTrackerCounters is a plain struct so isn't zero-initialised or anything. -- To view, visit http://gerrit.cloudera.org:8080/6502 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2434c952d97c46040e29fca2327c244dd30599d2 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
