Alex Behm has posted comments on this change. Change subject: IMPALA-5180: Don't balk at non-deterministic exprs ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6575/2/fe/src/main/java/org/apache/impala/analysis/Expr.java File fe/src/main/java/org/apache/impala/analysis/Expr.java: Line 1052: public boolean isStrictlyBoundBySlotIds(List<SlotId> slotIds) { I'm not a fan of this new function. It feels like a quick hack to solve a very narrow problem that nobody has ever complained about. I'm much more in favor of fixing the isBoundBy() family of functions to behave more appropriately when invoked on constant expressions. The changes I had in mind: - Must be invoked by a non-empty list of slot/tuple ids - Returns false for constant expressions - Maybe require that the expr must be analyzed? This one might be somewhat difficult and maybe not necessary for now -- To view, visit http://gerrit.cloudera.org:8080/6575 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91054c6bf017401242259a1eff5e859085285546 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
