David Knupp has posted comments on this change. Change subject: IMPALA-5181: Extract PYPI metadata from a webpage ......................................................................
Patch Set 1: I have to confess, I've long felt like there's lot of over engineering in the way that we set up the Impala python environment. E.g., pip allows for this usage: pip download -i <pypi_index> -r <requirements_file> --no-binary=:all: It doesn't download wheels, and it won't download packages that are already present, which I think is the main purpose of this file? It might mean that we have to update our version of pip in infra/python/env/bin as a first step, but if it works, it would obviate the need for a lot of this logic where bugs can hide. If this is the fastest solution to getting build working again so we can unlock the repo and start checking in code again, that's fine. But I think that there might be an easier way to do this. -- To view, visit http://gerrit.cloudera.org:8080/6579 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3845a0d5f568d4352e3cc4883596736974fd7de Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
