Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5181: Extract PYPI metadata from a webpage ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/6579/1/infra/python/deps/pip_download.py File infra/python/deps/pip_download.py: Line 73: if GET_METADATA_FROM_JSON: > Do we need to keep the JSON API version? The JSON code is cleaner but it se Removed. Line 74: REQUIRED_PKG_TYPE = 'sdist' # Wheel archives are not supported. > Perhaps a nit, but if we're considering REQUIRED_PKG_TYPE to be a "constant This is no longer relevant because this section of the code is removed. Line 83: url = '{0}/simple/{1}/'.format(PYPI_MIRROR, pkg_name) > Mention that this is the PEP 503 format in case people want to look at the Done Line 86: regex = r'<a href=\".*packages/(.*)#md5=(.*?)\".*>(.*)<\/a>' > I wasn't aware how early in the setup process this runs. In this case I agr Done. Made all qualifiers non-greedy. Added a comment explaining why we parse with regex. Line 91: if ( > nit: formatting of this seems weird. I'd probably prefer this (although I'l Done. I formatted it that way to satisfy flake8 formatter, but after researching it a bit, it's correct to write it the way you suggested too (even though flake8 complains). -- To view, visit http://gerrit.cloudera.org:8080/6579 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3845a0d5f568d4352e3cc4883596736974fd7de Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
