Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5181: Extract PYPI metadata from a webpage
......................................................................


Patch Set 1:

One thing to keep in mind is that we only have system pip available at this 
point, and the lowest-common denominator is pretty low. On CentOS 5, for 
example, "pip download" didn't exist, but pip install --download does. 

I actually made got that to work a while back, (with a hack to work around a 
problem with kudu-python): 
https://gerrit.cloudera.org/#/c/3217/1/infra/python/deps/download_requirements

I only added pip_download.py in the first place to avoid that hack but I agree 
the amount of work invested into this wasn't justified. Use JSON they said, 
it'll be easy they said :). That said, I think given the work we've sunk into 
it and the fact that it works, it seems easier to reason about than the 
behaviour of any possible version of pip from the last 10 years.

-- 
To view, visit http://gerrit.cloudera.org:8080/6579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If3845a0d5f568d4352e3cc4883596736974fd7de
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: David Knupp <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Taras Bobrovytsky <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: No

Reply via email to