David Knupp has posted comments on this change. Change subject: IMPALA-5181: Extract PYPI metadata from a webpage ......................................................................
Patch Set 1: Again, just wanted to reiterate that I think if this is the quickest path to unlocking the repo, this is an acceptable approach. I don't mean to hold this up. Discussions as to whether we should revisit the whole virtualenv workflow can happen elsewhere. In light of that... 1. I think Lars' point about adding a comment in the code as to why lxml (etc.) can't be used is still a good one. 2. Can you add a testing comment in the commit msg describing how this was tested. Did you try it against the default public PYPI, and also non-default mirror? -- To view, visit http://gerrit.cloudera.org:8080/6579 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3845a0d5f568d4352e3cc4883596736974fd7de Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
