Michael Ho has posted comments on this change. Change subject: IMPALA-5481: Clarify RowDescriptor ownership ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7206/2//COMMIT_MSG Commit Message: PS2, Line 18: Method arguments are either const* to convey that : ownership is to be shared, or const& to convey that the descriptor is to : be used but not mutated by the callee. Mind elaborating the purpose / meaning of shared ownership here ? Isn't a row_desc_ supposed to be a constant in all BE code ? Why not just use const& at all places ? http://gerrit.cloudera.org:8080/#/c/7206/2/be/src/exec/data-sink.h File be/src/exec/data-sink.h: PS2, Line 82: static Status Create(ObjectPool* pool, const TPlanFragmentCtx& fragment_ctx, : const TPlanFragmentInstanceCtx& fragment_instance_ctx, : const RowDescriptor* row_desc, DataSink** sink); May be I missed it but I don't see fragment-instance-state.cc in this diff. I thought it's where DataSink::Create() is called now ? -- To view, visit http://gerrit.cloudera.org:8080/7206 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fc39170f775581d406b6a97445046f508d8d75f Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
