Henry Robinson has posted comments on this change.

Change subject: IMPALA-5481: Clarify RowDescriptor ownership
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7206/2//COMMIT_MSG
Commit Message:

PS2, Line 18: Method arguments are either const* to convey that
            : ownership is to be shared, or const& to convey that the 
descriptor is to
            : be used but not mutated by the callee.
> Mind elaborating the purpose / meaning of shared ownership here ? Isn't a r
We have typically used T* to show that a T is not owned by the enclosing 
object. const T& works ok as well, but when you *use* the T, it looks 
indistinguishable from the actual object, which can lead to gotchas. If I'm 
dereferencing a pointer, I know by convention that the of the object is not 
necessarily the same as the pointer that refers to it.

Does that sound reasonable? Want to make sure I do something that's a) 
consistent and b) in line with everyone's expectations of how we express 
ownership.


-- 
To view, visit http://gerrit.cloudera.org:8080/7206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fc39170f775581d406b6a97445046f508d8d75f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-Reviewer: Michael Ho <[email protected]>
Gerrit-HasComments: Yes

Reply via email to