Alex Behm has posted comments on this change. Change subject: IMPALA-5500: Reduce catalog update topic size ......................................................................
Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/7268/5/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: Line 334: // Compress the catalog object remove (same as code) Line 367: compressed_data.resize(result_len); remove http://gerrit.cloudera.org:8080/#/c/7268/5/be/src/service/impala-server.h File be/src/service/impala-server.h: Line 556: Status DecompressCatalogObject(const TTopicItem& item, It's a little weird to have the Compress/Decompress functions in different classes and specific to catalog objects. How about we introduce static functions in SnappyCompressor like this: static Status Compress(string*); static Status Decompress(string*); Both compress/decompress in place using temporaries as necessary. Before you make the change, let me ask Tim what he thinks. -- To view, visit http://gerrit.cloudera.org:8080/7268 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f725cd8596205e6101d5b56abf08125faa30b0a Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-HasComments: Yes
