Tim Armstrong has posted comments on this change. Change subject: IMPALA-5500: Reduce catalog update topic size ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/7268/5/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: Line 358: RETURN_IF_ERROR(Codec::CreateCompressor(nullptr, false, THdfsCompression::SNAPPY, > LZ4 decompressor requires a pre-allocated output. The problem in this case I see - we're depending on MaxOutputLen() on the decompression path. Can't we include the uncompressed size along with the compressed data then? Seems like the right thing to do and a decent performance win. Otherwise we should explain why we're using Snappy here because it's subtle. -- To view, visit http://gerrit.cloudera.org:8080/7268 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f725cd8596205e6101d5b56abf08125faa30b0a Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
