Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5500: Reduce catalog update topic size ......................................................................
Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/7268/5/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: Line 358: RETURN_IF_ERROR(Codec::CreateCompressor(nullptr, false, THdfsCompression::SNAPPY, > I'm in favor of LZ4. Done Line 368: item_value->assign(reinterpret_cast<const char*>(compressed_data.data()), > Why do we need this extra copy here? It seems like we should serialize to a Done http://gerrit.cloudera.org:8080/#/c/7268/5/be/src/service/impala-server.h File be/src/service/impala-server.h: Line 556: Status DecompressCatalogObject(const TTopicItem& item, > It's a little weird to have the Compress/Decompress functions in different Done -- To view, visit http://gerrit.cloudera.org:8080/7268 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f725cd8596205e6101d5b56abf08125faa30b0a Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
