Tim Armstrong has posted comments on this change. Change subject: IMPALA-5500: Reduce catalog update topic size ......................................................................
Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/7268/5/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: Line 327: vector<uint8_t> serialized_object; Unused variable? Line 358: RETURN_IF_ERROR(Codec::CreateCompressor(nullptr, false, THdfsCompression::SNAPPY, Why not LZ4 to be consistent with what we do for exchanges? I don't have a problem with Snappy if we have some reason to use it but my understanding was that LZ4 was generally superior. Line 368: item_value->assign(reinterpret_cast<const char*>(compressed_data.data()), Why do we need this extra copy here? It seems like we should serialize to a string, then compress directly into the output string. That should be possible if we Serialize() into a temporary string then either compress it or move() it into the output string. http://gerrit.cloudera.org:8080/#/c/7268/5/be/src/service/impala-server.cc File be/src/service/impala-server.cc: PS5, Line 1293: reinterpret_cast<const uint8_t*>( Is this cast needed? vector<uint8_t>.data() should return uint8_t*. -- To view, visit http://gerrit.cloudera.org:8080/7268 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f725cd8596205e6101d5b56abf08125faa30b0a Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
