Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5240: Allow config of number of disk I/O threads per disk type ......................................................................
Patch Set 9: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/7232/9/be/src/runtime/disk-io-mgr.cc File be/src/runtime/disk-io-mgr.cc: PS9, Line 53: string num_io_threads_per_rotational_disk_help_msg = Substitute("Number of I/O threads" : " per rotational disk. Has priority over num_threads_per_disk. If neither is set, " : "defaults to $0 thread(s) per rotational disk", THREADS_PER_ROTATIONAL_DISK); : DEFINE_int32(num_io_threads_per_rotational_disk, 0, : num_io_threads_per_rotational_disk_help_msg.c_str()); hm I just played around with this and it doesn't actually work, which makes sense: the preprocessor expands the macro, but the string value doesn't get created until runtime. Sorry for the noise, can you just revert and mention the constant. Please just put a TODO above l48 to say if the constants are updated, the help message should be updated as well. -- To view, visit http://gerrit.cloudera.org:8080/7232 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I094aff3747104104fe0465d73dcdbef5d9892f7c Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
