Bikramjeet Vig has posted comments on this change. Change subject: IMPALA-5240: Allow config of number of disk I/O threads per disk type ......................................................................
Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/7232/9/be/src/runtime/disk-io-mgr.cc File be/src/runtime/disk-io-mgr.cc: PS9, Line 53: string num_io_threads_per_rotational_disk_help_msg = Substitute("Number of I/O threads" : " per rotational disk. Has priority over num_threads_per_disk. If neither is set, " : "defaults to $0 thread(s) per rotational disk", THREADS_PER_ROTATIONAL_DISK); : DEFINE_int32(num_io_threads_per_rotational_disk, 0, : num_io_threads_per_rotational_disk_help_msg.c_str()); @Matthew: as discussed, switched to a static const string instead which works as intended. @Tim: I wanted to avoid using macro constants as they are also being used during member initialization in the constructor PS9, Line 271: deafult_val > typo: default Done http://gerrit.cloudera.org:8080/#/c/7232/9/be/src/util/disk-info.h File be/src/util/disk-info.h: Line 61: if (disk_id >= disks_.size()) return false; > It shouldn't be in practice, but this is necessary for the tests which test Done -- To view, visit http://gerrit.cloudera.org:8080/7232 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I094aff3747104104fe0465d73dcdbef5d9892f7c Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
