Dan Hecht has posted comments on this change. Change subject: IMPALA-5240: Allow config of number of disk I/O threads per disk type ......................................................................
Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/7232/9/be/src/runtime/disk-io-mgr.h File be/src/runtime/disk-io-mgr.h: PS9, Line 631: This constructor is only used for testing. it's unfortunate that we have this at all. you don't have to fix it in this change, but I wonder why we can't just have the test set the FLAG_ variables, like in the real impalad environment. http://gerrit.cloudera.org:8080/#/c/7232/9/be/src/util/disk-info.h File be/src/util/disk-info.h: Line 61: if (disk_id >= disks_.size()) return false; why is this the right thing to assume? why should disk_id ever be more than the number of disks? -- To view, visit http://gerrit.cloudera.org:8080/7232 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I094aff3747104104fe0465d73dcdbef5d9892f7c Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
