Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5240: Allow config of number of disk I/O threads per disk type ......................................................................
Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/7232/9/be/src/util/disk-info.h File be/src/util/disk-info.h: Line 61: if (disk_id >= disks_.size()) return false; > why is this the right thing to assume? why should disk_id ever be more than It shouldn't be in practice, but this is necessary for the tests which test having # disk queues greater than the number of physical disks. Bikram filed a separate JIRA to make the tests more realistic. We should put a TODO with that JIRA number here to switch this back to a DCHECK later. -- To view, visit http://gerrit.cloudera.org:8080/7232 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I094aff3747104104fe0465d73dcdbef5d9892f7c Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
