Bikramjeet Vig has posted comments on this change. Change subject: IMPALA-4276: Profile displays non-default query options set by planner ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/7419/1//COMMIT_MSG Commit Message: PS1, Line 10: expilictly > explicitly Removing this, according to the comment in query-options.cc, this is not a bug PS1, Line 10: expilictly set : default query options were also populated in the runtime profile. > can you clarify what this means - what's an explicitly set default query op same as above http://gerrit.cloudera.org:8080/#/c/7419/1/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: PS1, Line 151: exec_request > nit: use exec_request_ Done http://gerrit.cloudera.org:8080/#/c/7419/1/be/src/service/query-options.cc File be/src/service/query-options.cc: PS1, Line 84: > can you quickly explain why this is right? It looks to me like we would wan Thanks for pointing that out. I was under the impression that all values had a default value set during initialization when I looked at ImpalaInternalService_types.h I now realize that some values dont have a default value set in the thrift file and this is indicated by __isset.NAME. Hence reverting this. http://gerrit.cloudera.org:8080/#/c/7419/1/tests/query_test/test_observability.py File tests/query_test/test_observability.py: PS1, Line 112: query = "set mem_limit = 0" > can you change this to some other query option, then test that MEM_LIMIT=8 Done -- To view, visit http://gerrit.cloudera.org:8080/7419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e9dc2bebb83101976bbbd903ee48c5068dbaab Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-HasComments: Yes
