Henry Robinson has posted comments on this change. Change subject: IMPALA-4276: Profile displays non-default query options set by planner ......................................................................
Patch Set 4: (2 comments) looks good, just one possible test concern. http://gerrit.cloudera.org:8080/#/c/7419/4/tests/query_test/test_observability.py File tests/query_test/test_observability.py: PS4, Line 107: assert expected_string in result.runtime_profile nit: might be more concise to write: assert expected_string in self.execute_query("select 1").runtime_profile PS4, Line 112: assert expected_string in result.runtime_profile This would get tripped up if the profile had: "Query Options ..... MT_DOP=0,MAX_IO_BUFFERS=0" I think you should also check that MAX_IO_BUFFERS=0 is not in the profile (perhaps with a regex to be sure that you're only checking the query options line). -- To view, visit http://gerrit.cloudera.org:8080/7419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e9dc2bebb83101976bbbd903ee48c5068dbaab Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
