Bikramjeet Vig has posted comments on this change. Change subject: IMPALA-4276: Profile displays non-default query options set by planner ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/7419/4/tests/query_test/test_observability.py File tests/query_test/test_observability.py: PS4, Line 107: assert expected_string in result.runtime_profile > nit: might be more concise to write: Done PS4, Line 112: assert expected_string in result.runtime_profile > This would get tripped up if the profile had: added a "\n" at the end of expected_String to make sure that MAX_IO_BUFFERS=0 is not a part of the query options line -- To view, visit http://gerrit.cloudera.org:8080/7419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e9dc2bebb83101976bbbd903ee48c5068dbaab Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-HasComments: Yes
