Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4276: Profile displays non-default query options set by planner ......................................................................
Patch Set 3: Code-Review+1 (1 comment) LGTM with 1 small test change. Let's wait to see if Henry wants to add anything else. http://gerrit.cloudera.org:8080/#/c/7419/3/tests/query_test/test_observability.py File tests/query_test/test_observability.py: PS3, Line 101: query = "set mem_limit = 8589934592" : self.execute_query(query) here and below, I don't see any reason to define these short queries as a local variable, just pass the strings directly to execute_query(...) -- To view, visit http://gerrit.cloudera.org:8080/7419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e9dc2bebb83101976bbbd903ee48c5068dbaab Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
