Alex Behm has posted comments on this change. Change subject: IMPALA-5776: Write partial tuple to the correct mempool ......................................................................
Patch Set 3: (7 comments) I like the new solution, it's easier to understand. http://gerrit.cloudera.org:8080/#/c/7639/2/be/src/exec/hdfs-text-scanner.cc File be/src/exec/hdfs-text-scanner.cc: Line 269: while (true) { > It's used on line 277. Are you suggesting to remove it from the signature o Oh I missed that sorry. Ok to leave. http://gerrit.cloudera.org:8080/#/c/7639/3/be/src/exec/hdfs-text-scanner.cc File be/src/exec/hdfs-text-scanner.cc: Line 804: // Copy over all materialized slots in the partial tuple. Only describes what the code does. How about something like: // Deep copy to simplify memory ownership. Line 808: // prevent the accumulation of variable length data in it. We also recreate the The partial tuple isn't re-created here http://gerrit.cloudera.org:8080/#/c/7639/3/be/src/exec/hdfs-text-scanner.h File be/src/exec/hdfs-text-scanner.h: Line 186: /// Utility function to write out 'num_fields' to 'tuple_'. This is used to parse Comment is weird, I suggest rephrasing to something like: Utility function to parse 'num_fields' and materialize the resulting slots into 'partial_tuple_'. The data of var-len fields is copied into 'partial_tuple_pool_'. Line 227: /// Mem pool for the partial tuple. Mention that it does not hold tuple data of returned batches because the data is always deep-copied into the output batch Line 230: /// Memory to store partial tuples split across buffers. Memory comes from Mention that this tuple is always deep copied into the output batch Line 231: /// partial_tuple_pool_. There is only one tuple allocated for this object and reused The 2nd sentence does not seem to apply anymore because we realloc the partial_tuple_ -- To view, visit http://gerrit.cloudera.org:8080/7639 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60ba5c113aefd17f697c1888fd46a237ef396540 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
