Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5776: Write partial tuple to the correct mempool ......................................................................
Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/7639/3/be/src/exec/hdfs-text-scanner.cc File be/src/exec/hdfs-text-scanner.cc: Line 804: // Copy over all materialized slots in the partial tuple. > Only describes what the code does. How about something like: Done Line 808: // prevent the accumulation of variable length data in it. We also recreate the > The partial tuple isn't re-created here Done http://gerrit.cloudera.org:8080/#/c/7639/3/be/src/exec/hdfs-text-scanner.h File be/src/exec/hdfs-text-scanner.h: Line 186: /// Utility function to write out 'num_fields' to 'tuple_'. This is used to parse > Comment is weird, I suggest rephrasing to something like: Done Line 227: /// Mem pool for the partial tuple. > Mention that it does not hold tuple data of returned batches because the da Done Line 230: /// Memory to store partial tuples split across buffers. Memory comes from > Mention that this tuple is always deep copied into the output batch Done Line 231: /// partial_tuple_pool_. There is only one tuple allocated for this object and reused > The 2nd sentence does not seem to apply anymore because we realloc the part Done -- To view, visit http://gerrit.cloudera.org:8080/7639 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60ba5c113aefd17f697c1888fd46a237ef396540 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
