Matthew Jacobs has uploaded a new patch set (#3). Change subject: IMPALA-5644: Reject queries if min reservation is too large ......................................................................
IMPALA-5644: Reject queries if min reservation is too large Rejects queries during admission control if: * the largest (across all backends) min buffer reservation is greater than the query mem_limit or buffer_pool_limit * the sum of the min buffer reservations across the cluster is larger than the pool max mem resources There are some other interesting cases to consider later: * every per-backend min buffer reservation is less than the associated backend's process mem_limit; the current admission control code doesn't know about other backend's proc mem_limits. Some minor code refactoring in admission-controller and query-state. Testing: * Added new test cases in test_admission_controller.py Change-Id: Iabe87ce8f460356cfe4d1be4d7092c5900f9d79b --- M be/src/runtime/bufferpool/CMakeLists.txt M be/src/runtime/bufferpool/reservation-tracker-test.cc A be/src/runtime/bufferpool/reservation-util.cc A be/src/runtime/bufferpool/reservation-util.h M be/src/runtime/query-state.cc M be/src/scheduling/admission-controller.cc M be/src/scheduling/admission-controller.h M be/src/scheduling/scheduler.h M common/thrift/generate_error_codes.py M tests/custom_cluster/test_admission_controller.py 10 files changed, 279 insertions(+), 64 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/78/7678/3 -- To view, visit http://gerrit.cloudera.org:8080/7678 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iabe87ce8f460356cfe4d1be4d7092c5900f9d79b Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
