Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5644: Reject queries if min reservation is too large ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7678/2/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: Line 401: // Compute the max (over all backends) min_reservation_bytes and the cluster total > Yeah that's true, we do have that in the profile. Yeah maybe this should mention the profile. Perhaps I won't point to a particular field, but something more general like appending: "See the query profile for more information." What do you think of that at the end of the 3 new error strings? I was going to file a JIRA to track making the schedule more observable, but JIRA isn't responding. Will do that later. http://gerrit.cloudera.org:8080/#/c/7678/3/common/thrift/generate_error_codes.py File common/thrift/generate_error_codes.py: PS3, Line 332: > Nit: don't need space before colon Done -- To view, visit http://gerrit.cloudera.org:8080/7678 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iabe87ce8f460356cfe4d1be4d7092c5900f9d79b Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
